constify result unwrap unchecked #148333
Open
constify result unwrap unchecked #148333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
clarfonthey
reviewed
Nov 1, 2025
| // SAFETY: the safety contract must be upheld by the caller. | ||
| Err(_) => unsafe { hint::unreachable_unchecked() }, | ||
| Err(e) => { | ||
| super::mem::forget(e); |
Contributor
There was a problem hiding this comment.
This should be annotated as a const hack so it can potentially be fixed later:
// FIXME(const-hack): to avoid E: const Destruct bound
bend-n
force-pushed
the
const_result_unwrap_unchecked
branch
from
05b1251 to
c15b256
Compare
This comment has been minimized.
This comment has been minimized.
bend-n
force-pushed
the
const_result_unwrap_unchecked
branch
from
c15b256 to
991b449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constifies unwrap unchecked on result
will make tracking issue if good